Skip to content

fix(help-center): move SharePoint icon after link text#5450

Merged
fpigeonjr merged 1 commit into
mainfrom
ops-5315/sp-icon
Apr 8, 2026
Merged

fix(help-center): move SharePoint icon after link text#5450
fpigeonjr merged 1 commit into
mainfrom
ops-5315/sp-icon

Conversation

@fpigeonjr

@fpigeonjr fpigeonjr commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

What changed

Moved the SharePoint external-link icon to appear after the link text in the Help Center and swapped the glyph to the external-link style used for this action.

Issue

NA

How to test

  • Open the Help Center page
  • Confirm the SharePoint link shows the icon after the text
  • Confirm the link still opens in a new tab
  • Verify bun run lint and bun run test --watch=false pass

A11y impact

  • No accessibility-impacting changes in this PR
  • Accessibility changes included and validated against WCAG 2.1 AA intent
  • Any temporary suppression includes A11Y-SUPPRESSION metadata (owner, expires, rationale)

Screenshots

image

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

Links

N/A

@fpigeonjr fpigeonjr marked this pull request as ready for review April 7, 2026 23:15
@fpigeonjr fpigeonjr merged commit ac4994d into main Apr 8, 2026
58 checks passed
@fpigeonjr fpigeonjr deleted the ops-5315/sp-icon branch April 8, 2026 15:28
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.355.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants